kacpermuda commented on PR #58057: URL: https://github.com/apache/airflow/pull/58057#issuecomment-3540715206
I considered that approach as well, but ultimately decided to go with the polyfill implementation. The code isn’t very complex in the end, and since it’s only executed once for a singleton collector instance, the overhead is minimal. I understand that maintaining it could be more challenging compared to a no-op, and that ideally, users should upgrade Airflow to benefit from the latest features. However, in my view, the value this solution provides outweighs the effort required to implement and maintain it. That said, if this is a hard no or a blocker for you, I’m happy to adjust the code and switch to a no-op. But if you think there’s room to proceed with the polyfill approach, I’d be glad to make any changes needed to align it better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
