gfreitash commented on PR #57631:
URL: https://github.com/apache/airflow/pull/57631#issuecomment-3542062537
I applied the reviews suggested. On that topic though, should I mark the
reviews as resolved myself or the reviewer or other maintained will do that?
Besides that, the tests are failing due to changes done in #58147.
Apparently there is no supervisor available on my test and I am unsure how to
add it. I could confirm that my test pass by modifying
`task_runner::reinit_supervisor_comms` to return early if the file descriptor
is the default
```
fd = int(os.environ.get("__AIRFLOW_SUPERVISOR_FD", "0"))
if fd == 0:
return
SUPERVISOR_COMMS = CommsDecoder[ToTask, ToSupervisor](log=log,
socket=socket.socket(fileno=fd))
```
I did not commit it though, first because I don't think it is part of this
PR and second because I am not even sure this is the correct approach to the
issue itself. What are your thoughts on it, @ashb?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
