potiuk commented on code in PR #58394: URL: https://github.com/apache/airflow/pull/58394#discussion_r2534968206
########## clients/python/CHANGELOG.md: ########## @@ -17,6 +17,27 @@ under the License. --> +# v3.1.3 + +## Major changes: + +- Add query limit protection to prevent excessive database queries in DAG runs list endpoints ([#57450](https://github.com/apache/airflow/pull/57450)) +- Change `extra` field type to `dict[str, JsonValue]` for Asset, AssetAlias, and AssetEvent models ([#57352](https://github.com/apache/airflow/pull/57352)) Review Comment: Question. Are you going to release python client for `main` @ephraimbuddy ? I am not sure if this is the **best** idea - similarly like with `airflow-ctl` - last time I checked, there were differences between the API in main and v3-1-test as some of the changes were not cherr-picked. As far as I remember the change in assets was something that drew my attention. Last time I checked, they were **not** v3-1-test - which means they are not in 3.1.3. Now - I am not sure what consequences it will have - if that's the same with the Python Client, and whether it is backwards compatible or not, but I think that might mean that: 1) It's safer to release the client from v3-1-test 2) Before we release 3.2 - probably some back-compatibility testing should be done in main to see if the changes in API for 3.2 are actually compatible with 3.1 (and for sure at least manual verification and thinking through compatibility scenaros) (old client - new airflow, old airflow - new client) and acting accordingly (which I think we do not have any process for, no guardrails and no tests in place). ########## clients/python/CHANGELOG.md: ########## @@ -17,6 +17,27 @@ under the License. --> +# v3.1.3 + +## Major changes: + +- Add query limit protection to prevent excessive database queries in DAG runs list endpoints ([#57450](https://github.com/apache/airflow/pull/57450)) +- Change `extra` field type to `dict[str, JsonValue]` for Asset, AssetAlias, and AssetEvent models ([#57352](https://github.com/apache/airflow/pull/57352)) Review Comment: Question. Are you going to release python client for `main` @ephraimbuddy ? I am not sure if this is the **best** idea - similarly like with `airflow-ctl` - last time I checked, there were differences between the API in main and v3-1-test as some of the changes were not cherr-picked. As far as I remember the change in assets was something that drew my attention. Last time I checked, they were **not** in v3-1-test - which means they are not in 3.1.3. Now - I am not sure what consequences it will have - if that's the same with the Python Client, and whether it is backwards compatible or not, but I think that might mean that: 1) It's safer to release the client from v3-1-test 2) Before we release 3.2 - probably some back-compatibility testing should be done in main to see if the changes in API for 3.2 are actually compatible with 3.1 (and for sure at least manual verification and thinking through compatibility scenaros) (old client - new airflow, old airflow - new client) and acting accordingly (which I think we do not have any process for, no guardrails and no tests in place). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
