potiuk commented on issue #53637: URL: https://github.com/apache/airflow/issues/53637#issuecomment-3547265189
> I'm sorry that I cann't answer any of the design nor the existence question. I don't thing @Srabasti is asking you particularly to solve it, somene could help but mostly it's up to someone to see the current state of things (we are currently in the stage of moving of stuff for APIs between airflow-core and task-sdk) and find out what was really the reasoning, why things were there and how to fix it. It's not **obvious** but it's also **changing** currently - and depends on which parts have been moved and which weren't. > But, without fixing it, the document will always provide the incorrect information. Well. That's a bit of truism. But It is important to discuss and agree **how** to fix it best. I think personally (and that was my comment to @cmarteepants above who I think originally moved the examples to the .rst files) that tn order to fix it (and keep it working) - it needs to be not only fixed but turned back into our "include" pattern and it should really be part of the https://cwiki.apache.org/confluence/display/AIRFLOW/Examples+Refurbish initiatives where we plan to - eventually - review and make our examples far more consistent and usable. The idea with include patterns of ours is that all the example dags we include are also PARSED during our tests and prek-hooks - which means that they **at least** do not cause import errrors and warnings with the current "main` state of things - which means that it's far more difficult to get such an out-dated example that is lying around until someone notices, because our CI system makes sure that whenever someone modifies and refactors code, the examples are still **working** with it - so they basically force anyone who is refactoring the code to also modify the examples. I am not sure **how exactly** to fix this particular example, but I think after this fix is complete our goal is not only to fix it but also leave it in the state that it will be more difficult to break it in the future accidentally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
