potiuk commented on PR #58460: URL: https://github.com/apache/airflow/pull/58460#issuecomment-3549957695
> Yeah also thought about this... maybe just calling eslint after adding keys? (If you can not win over your enemy just take it in your arms :-D) Yeah Good idea. > Wondering though that this did not yell at static checks on the PR where this was merged though. Or also prek when adding changes locally... Hmm. That makes me think something that @amoghrajesh I think thought about - turning the "check_translation_completness" script into a litle bit more complete breeze command that will simply run `prek eslint` after generating the translations? `breeze ui check-translation-completness` (and also moving compile-ui-assets to `ui`) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
