amoghrajesh commented on code in PR #58506:
URL: https://github.com/apache/airflow/pull/58506#discussion_r2544254262
##########
airflow-core/docs/howto/deadline-alerts.rst:
##########
@@ -58,7 +58,8 @@ Below is an example Dag implementation. If the Dag has not
finished 15 minutes a
from datetime import datetime, timedelta
from airflow import DAG
- from airflow.sdk.definitions.deadline import AsyncCallback, DeadlineAlert,
DeadlineReference
+ from airflow.sdk.definitions.callback import AsyncCallback
+ from airflow.sdk.definitions.deadline import DeadlineAlert,
DeadlineReference
Review Comment:
Maybe we can have a lazy import for these?
See connections/variables for example, you can do: `from airflow.sdk import
Connection, Variable`
##########
airflow-core/docs/howto/deadline-alerts.rst:
##########
@@ -58,7 +58,8 @@ Below is an example Dag implementation. If the Dag has not
finished 15 minutes a
from datetime import datetime, timedelta
from airflow import DAG
- from airflow.sdk.definitions.deadline import AsyncCallback, DeadlineAlert,
DeadlineReference
+ from airflow.sdk.definitions.callback import AsyncCallback
+ from airflow.sdk.definitions.deadline import DeadlineAlert,
DeadlineReference
Review Comment:
If we do this, dag authors are shielded from such changes to _subpaths_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
