henry3260 commented on issue #58434:
URL: https://github.com/apache/airflow/issues/58434#issuecomment-3556111093
Hi @arjunanan6, thanks for your feedback. I wanted to clarify my proposal
based on your comments:
1. Regarding Dictionary Support: While you mentioned that users can
directly pass a dictionary for identity (e.g., identity={"type":
"UserAssigned", ...}), this doesn’t fully address the problem of input
validation. From my understanding, the current implementation works with
dictionaries because of Azure SDK’s leniency—it implicitly accepts correctly
structured dictionaries. However, this approach lacks early validation at the
operator level, which means errors due to improperly formatted dictionaries
(e.g., missing type or invalid resource_ids) will only surface at runtime when
calling the Azure SDK. My proposal aims to handle these dictionaries explicitly
at the operator level, converting them into ContainerGroupIdentity and
performing early validation. This ensures friendlier user feedback and avoids
unexpected runtime failures.
2. Maintaining Consistency: I understand your concern with keeping the
operator’s design consistent with the SDK. However, adding lightweight
processing like _ensure_identity wouldn’t disrupt the current design but
instead makes the operator more user-focused and resilient. It provides
ergonomic improvements, allowing users to pass simpler configurations while
still preserving the flexibility for those who wish to use
ContainerGroupIdentity directly.
I hope this clarifies my approach. Let me know if further details are
needed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
