pierrejeambrun commented on code in PR #57594:
URL: https://github.com/apache/airflow/pull/57594#discussion_r2545477346
##########
airflow-core/src/airflow/ui/src/pages/Variables/Variables.tsx:
##########
@@ -226,17 +225,6 @@ export const Variables = () => {
<Tooltip content={translate("variables.delete.tooltip")}>
<DeleteVariablesButton clearSelections={clearSelections}
deleteKeys={[...selectedRows.keys()]} />
</Tooltip>
- <Tooltip content={translate("variables.exportTooltip")}>
Review Comment:
To remove from translations file. `variables.exportTooltip`
##########
airflow-core/src/airflow/ui/src/pages/Variables/Variables.tsx:
##########
@@ -226,17 +225,6 @@ export const Variables = () => {
<Tooltip content={translate("variables.delete.tooltip")}>
<DeleteVariablesButton clearSelections={clearSelections}
deleteKeys={[...selectedRows.keys()]} />
</Tooltip>
- <Tooltip content={translate("variables.exportTooltip")}>
- <Button
- colorPalette="info"
- onClick={() => downloadJson(selectedVariables, "variables")}
- size="sm"
- variant="outline"
- >
- <FiShare />
- {translate("variables.export")}
Review Comment:
To remove from translation files.
##########
airflow-core/src/airflow/ui/src/pages/Variables/Variables.tsx:
##########
@@ -226,17 +225,6 @@ export const Variables = () => {
<Tooltip content={translate("variables.delete.tooltip")}>
<DeleteVariablesButton clearSelections={clearSelections}
deleteKeys={[...selectedRows.keys()]} />
</Tooltip>
- <Tooltip content={translate("variables.exportTooltip")}>
- <Button
- colorPalette="info"
- onClick={() => downloadJson(selectedVariables, "variables")}
Review Comment:
`downloadJson` seems to only be used here, and should probably be deleted
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
