ephraimbuddy commented on code in PR #58513:
URL: https://github.com/apache/airflow/pull/58513#discussion_r2545722104


##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -170,13 +182,19 @@ Then open a PR and merge it into main.
 
 ```shell script
 cd ${AIRFLOW_REPO_ROOT}
-git tag -s python-client/${VERSION}${VERSION_SUFFIX} -m "Airflow Python Client 
${VERSION}${VERSION_SUFFIX}"
-git push apache python-client/${VERSION}${VERSION_SUFFIX}
+git tag -s python-client/${VERSION_RC} -m "Airflow Python Client ${VERSION_RC}"
+git push origin python-client/${VERSION_RC}

Review Comment:
   ```suggestion
   git push apache python-client/${VERSION_RC}
   ```



##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -156,8 +168,8 @@ cd ${CLIENT_REPO_ROOT}
 git diff HEAD
 git checkout -b release-${VERSION}
 git add .
-git commit -m "Update Python Client to ${VERSION}${VERSION_SUFFIX}"
-git push apache release-${VERSION}
+git commit -m "Update Python Client to ${VERSION_RC}"
+git push origin release-${VERSION}

Review Comment:
   ```suggestion
   git push apache release-${VERSION}
   ```



##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -170,13 +182,19 @@ Then open a PR and merge it into main.
 
 ```shell script
 cd ${AIRFLOW_REPO_ROOT}
-git tag -s python-client/${VERSION}${VERSION_SUFFIX} -m "Airflow Python Client 
${VERSION}${VERSION_SUFFIX}"
-git push apache python-client/${VERSION}${VERSION_SUFFIX}
+git tag -s python-client/${VERSION_RC} -m "Airflow Python Client ${VERSION_RC}"
+git push origin python-client/${VERSION_RC}
 cd ${CLIENT_REPO_ROOT}
-git tag -s ${VERSION}${VERSION_SUFFIX} -m "Airflow Python Client 
${VERSION}${VERSION_SUFFIX}"
-git push apache tag ${VERSION}${VERSION_SUFFIX}
+git tag -s ${VERSION_RC} -m "Airflow Python Client ${VERSION_RC}"
+git push origin tag ${VERSION_RC}

Review Comment:
   ```suggestion
   git push apache tag ${VERSION_RC}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to