glennhsh opened a new pull request, #58547:
URL: https://github.com/apache/airflow/pull/58547
This commit improves the configuration and scaling logic for Celery Worker
Sets, allowing for more robust multi-queue setups.
Key changes:
1. **Strict KEDA Queue Filtering**: Updated KEDA SQL queries to always
include `AND queue = '...'`. Previously, the default worker's KEDA query could
incorrectly include tasks from other queues (e.g., those assigned to specific
worker sets), leading to incorrect scaling behavior.
2. **Explicit Default Worker Toggle**: Introduced `workers.enableDefault`
(default: `true`). This allows users to easily disable the default worker if
they wish to rely solely on custom worker sets for specific queues, improving
configuration clarity.
3. **Independent Resource Generation**: Refactored HPA and KEDA templates
to generate resources for the default worker and worker sets independently.
This resolves issues where the default worker's autoscaling resources were
sometimes suppressed when sets were defined.
4. **Test Updates**: Updated Helm tests to verify the new queue filtering
logic and the independent generation of worker resources.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
