jason810496 commented on code in PR #58575:
URL: https://github.com/apache/airflow/pull/58575#discussion_r2552463912
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -591,6 +593,74 @@ def full_tests_needed(self) -> bool:
return True
return False
+ def _is_large_enough_pr(self) -> bool:
+ """
+ Check if PR is large enough to run full tests.
+
+ The heuristics are based on number of files changed and total lines
changed,
+ while excluding generated files which can be ignored.
+ """
+ FILE_THRESHOLD = 25
+ LINE_THRESHOLD = 500
+
+ if not self._files:
+ return False
+
+ exclude_patterns = [
+ r"/newsfragments/",
+ r"^uv\.lock$",
+ r"pnpm-lock\.yaml$",
+ r"package-lock\.json$",
+ ]
Review Comment:
Should we exclude the SVG files such as output of Breeze CLI and DB ERD?
Since those SVG files difference will tend to be larger than
`LINE_THRESHOLD` even the actual changes are just a few lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
