OscarLigthart opened a new pull request, #58582:
URL: https://github.com/apache/airflow/pull/58582
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
## Context
After reimplementing the task stream filter in Airflow 3, a feature request
was raised by @bbovenzi to add a level parameter in this filtering
functionality. In this way, a user could more easily "traverse" a complex DAG
when debugging. It will also be easier to see direct dependencies on the more
dense nodes.
Related: #58450
## Examples
Besides the added test, I hooked it up to the frontend to give the reviewer
a bit more of an idea of what's happening:
Original:
<img width="1155" height="503" alt="image"
src="https://github.com/user-attachments/assets/2895fae1-2d64-4334-ad8a-bfcdef98a4fd";
/>
With root `section_1.task_3` and depth 2:
<img width="1156" height="485" alt="image"
src="https://github.com/user-attachments/assets/a5d385f4-0fbc-4896-abef-4943b0b491e8";
/>
With root `section_1.task_3` and depth 1:
<img width="1145" height="714" alt="image"
src="https://github.com/user-attachments/assets/c88ae5c8-b293-4b31-ae5c-88cdb99e7ef6";
/>
## Note to Reviewer
I found some odd behaviour in the frontend when setting depth 0. The
singular task is correctly shown, but keeps rerendering until it disappears.
This behaviour **only** happens on depth 0. Depth > 1, it works perfectly well.
The tests pass, and following the code, I find I get the expected results.
Not sure if this is a bug in the frontend. Thought it would be good to mention
it at least. I considered setting the minimum accepted value at 1 but I feel 0
should be accepted too.
Happy to discuss further.
## Testing
I created two scenario's which should show the reviewer the behaviour on a
small scale and help verify the functionality. Let me know if there is any need
to further elaborate on this.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
