potiuk commented on code in PR #58593: URL: https://github.com/apache/airflow/pull/58593#discussion_r2554261194
########## dev/breeze/tests/test_packages.py: ########## @@ -401,6 +401,23 @@ def test_apply_version_suffix_to_provider_pyproject_toml(provider_id, version_su AIRFLOWCTL_INIT_PY = AIRFLOW_ROOT_PATH / "airflow-ctl" / "src" / "airflowctl" / "__init__.py" [email protected] Review Comment: Wait. .... But would not that break things in the *other* direction? I can imagine that two tests that expect those versions to be updated might also be broken by this - because fixture wll FIX the versions if the race condition happens? I think we need to either have some lock for those changes or to avoid in-place modifications - maybe just mock the "read" method for the tests reading the version rather than modify the files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
