amoghrajesh commented on code in PR #58515:
URL: https://github.com/apache/airflow/pull/58515#discussion_r2555131419
##########
airflow-core/docs/security/secrets/mask-sensitive-values.rst:
##########
@@ -58,7 +92,7 @@ your Dag file or operator's ``execute`` function using the
``mask_secret`` funct
@task
def my_func():
- from airflow.sdk.log import mask_secret
+ from airflow.sdk.execution_time.secrets_masker import mask_secret
Review Comment:
We should use `sdk.log`, thats the public interface
##########
airflow-core/docs/security/secrets/mask-sensitive-values.rst:
##########
@@ -38,16 +40,48 @@ Sensitive field names
When masking is enabled, Airflow will always mask the password field of every
Connection that is accessed by a
task.
-It will also mask the value of a Variable, rendered template dictionaries,
XCom dictionaries or the
-field of a Connection's extra JSON blob if the name is in the list of
known-sensitive fields (i.e. 'access_token',
-'api_key', 'apikey', 'authorization', 'passphrase', 'passwd', 'password',
'private_key', 'secret' or 'token').
-This list can also be extended:
+It will also mask the value of an Airflow Variable , rendered template
dictionaries, XCom dictionaries or the field of a Connection's extra JSON blob
if the
Review Comment:
```suggestion
It will also mask the value of an Airflow Variable, rendered template
dictionaries, XCom dictionaries or the field of a Connection's extra JSON blob
if the
```
##########
airflow-core/docs/security/secrets/mask-sensitive-values.rst:
##########
@@ -71,7 +105,7 @@ or
class MyOperator(BaseOperator):
def execute(self, context):
- from airflow.sdk.log import mask_secret
+ from airflow.sdk.execution_time.secrets_masker import mask_secret
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
