pierrejeambrun commented on code in PR #53216:
URL: https://github.com/apache/airflow/pull/53216#discussion_r2556395203


##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/ui/common.py:
##########
@@ -79,6 +79,9 @@ class GridRunsResponse(BaseModel):
     run_after: datetime
     state: DagRunState | None
     run_type: DagRunType
+    dag_version_number: int | None = None
+    bundle_version: str | None = None
+    has_mixed_versions: bool = False

Review Comment:
   Same for this. You don't need to compute it. We have the `get_dag_run` query 
in the context of the grid, that returns `dag_versions` already, if the list is 
bigger than 1 we have mixed version. (only thing is that this list consider 
TaskInstanceHistory too, which might or might not be appropriate depending on 
how we want to visualize things)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to