aaron-wolmutt commented on code in PR #58292: URL: https://github.com/apache/airflow/pull/58292#discussion_r2557021598
########## airflow-core/src/airflow/api_fastapi/auth/managers/models/base_user.py: ########## @@ -18,13 +18,35 @@ from __future__ import annotations from abc import abstractmethod +from typing import TYPE_CHECKING + +if TYPE_CHECKING: + from typing import Any class BaseUser: - """User model interface.""" + """User model interface. These attributes/methods should be implemented in the pluggable auth manager.""" + + id: int | str | None + first_name: str | None + last_name: str | None + username: str | None + role: str | None + email: str | None + active: bool | None + roles: list[Any] | None Review Comment: I think just adding a single getter in the base user class and leaving it up to the provider to implement might be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
