sunank200 commented on code in PR #58662:
URL: https://github.com/apache/airflow/pull/58662#discussion_r2558935481
##########
task-sdk/src/airflow/sdk/execution_time/secrets_masker.py:
##########
@@ -27,17 +27,25 @@
import warnings
+# Note: This import from airflow-core is ok, as this is a compatibility module
which we will remove in 3.2 anyways
+from airflow.utils.deprecation_tools import DeprecatedImportWarning
+
warnings.warn(
"Importing from 'airflow.sdk.execution_time.secrets_masker' is deprecated
and will be removed in a future version. "
"Please use 'airflow.sdk._shared.secrets_masker' instead.",
- DeprecationWarning,
+ DeprecatedImportWarning,
stacklevel=2,
)
def __getattr__(name: str):
"""Dynamically import attributes from the shared secrets_masker
location."""
try:
+ if name == "mask_secret":
+ from airflow.sdk.log import mask_secret
Review Comment:
I cannot think of it right now, but can `airflow.sdk.log` import fail inside
`getattr`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
