ashb commented on code in PR #58594:
URL: https://github.com/apache/airflow/pull/58594#discussion_r2558956719
##########
devel-common/src/tests_common/pytest_plugin.py:
##########
Review Comment:
Changes in this file seem unrelated andto unnecessary to this pr?
##########
devel-common/src/tests_common/pytest_plugin.py:
##########
@@ -36,7 +36,12 @@
import pytest
import time_machine
-from _pytest.config.findpaths import ConfigValue
+try:
+ from _pytest.config.findpaths import ConfigValue
+except ImportError:
+ from collections import namedtuple
+
+ ConfigValue = namedtuple("ConfigValue", ["value", "origin", "mode"])
Review Comment:
What's this for?
##########
devel-common/pyproject.toml:
##########
@@ -39,7 +39,7 @@ dependencies = [
"semver>=3.0.2",
"typer-slim>=0.15.1",
# limited due to changes needed
https://github.com/apache/airflow/issues/58470
- "time-machine>=2.19.0, <3.0.0",
+ "time-machine>=2.19.0",
Review Comment:
We should a. Remove the comment, and b. Probably specify >=3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
