Ankurdeewan commented on code in PR #56324: URL: https://github.com/apache/airflow/pull/56324#discussion_r2558989203
########## tests/system/providers/google/common/example_quota_project_system.py: ########## @@ -0,0 +1,112 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: @VladaZakharova, thanks for pointing that out. You're right, this one fails immediately because it tries to load real ADC quota-project credentials. It doesn’t really guard itself the way some of the other Google system tests do, so it ends up running even when the environment isn’t set up for it. My intention wasn’t to turn this into a full integration test, mainly just to move the example DAG into the proper system-test layout so it matches the rest of the Google provider. If this isn’t something that should run as a system test, I can add a simple skip when ADC isn’t present, or move it out of that folder entirely. Just let me know which direction you'd prefer and ill follow that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
