VladaZakharova commented on PR #56445: URL: https://github.com/apache/airflow/pull/56445#issuecomment-3575233849
Hi there everyone. Thank you for waiting! We have discussed this inside the team and wanted to propose some changes. 1. Change the parent class of the desired trigger to BaseEventTrigger. This means, that for current implementation for PubSub it will require the change of base class to BaseEventTrigger, which basically will only extend the current funtionality and will not break any code for the trigger existing logic, but will fix the need to add ignore tag as here: https://github.com/apache/airflow/pull/56445/files#diff-35c447dab2b24d97f627e395892d4810a15a4faffc619ebfad03e02c1bf5242eR68 2. Implement a new class in providers/google/src/airflow/providers/google/event_scheduling/events/…..py that will inherit from BaseMessageQueueProvider and have a method. Naming should be like `PubSubMessageQueueEventTriggerContainer` Since right now the suggested name has `Provider` in it, which is very much confusing and can mistake user. New suggested name will fix this misunderstanding. Also, since the idea itself is to implement logic for event-driven scheduling, the proposed idea includes this kind of naming convention for the folders/files. In this way, it will be more clear for the user where to add new assets or events when extending logic for event scheduling in Airflow: https://screenshot.googleplex.com/GauARo3y86HyvcA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
