vincbeck commented on code in PR #58605: URL: https://github.com/apache/airflow/pull/58605#discussion_r2560364951
########## providers/keycloak/docs/auth-manager/manage/login.rst: ########## @@ -0,0 +1,111 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +================================================ Review Comment: Overall could you pass this doc through an AI to rephrase/fix some sentences? I feel like some sentence could be better formulated. ########## contributing-docs/21_keycloak_client_settings.rst: ########## @@ -0,0 +1,47 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +Setting up Keycloak Client for Breeze +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +To fully work with Keycloak in local Airflow development with Breeze, you need to set up a Keycloak client. +While creating client there is a section called ``Login Settings`` or after creation it is ``Access Settings``. Review Comment: Maybe better? ```suggestion To fully integrate Keycloak into local Airflow development with Breeze, you need to set up a Keycloak client. During client creation, the relevant section is called ``Login Settings``. After the client is created, this section is renamed to ``Access Settings``. ``` ########## contributing-docs/21_keycloak_client_settings.rst: ########## @@ -0,0 +1,47 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +Setting up Keycloak Client for Breeze Review Comment: Maybe also mention the parameter `--integration keycloak` in breeze? That's very helpful. And actually when using it, do you do not need to configure anything, it comes out of the box -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
