potiuk commented on PR #58715:
URL: https://github.com/apache/airflow/pull/58715#issuecomment-3580354350
Ah. No... It should we be way simpler. I prefer to do condiongs in
selective_check - they are easier to test and reason about:
```python
@cached_property
def ci_image_build(self) -> bool:
# in case pyproject.toml changed, CI image should be built - even if
no build dependencies
# changes because some of our tests - those that need CI image might
need to be run depending on
# changed rules for static checks that are part of the
pyproject.toml file
return (
self.run_unit_tests
or self.docs_build
or self.run_kubernetes_tests
or self.run_task_sdk_integration_tests # <--- ADD THIS LINE
or self.run_helm_tests
or self.run_ui_tests
or self.pyproject_toml_changed
or self.any_provider_yaml_or_pyproject_toml_changed
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
