ephraimbuddy commented on code in PR #58248:
URL: https://github.com/apache/airflow/pull/58248#discussion_r2564438062


##########
airflow-core/src/airflow/models/serialized_dag.py:
##########
@@ -470,6 +578,15 @@ def write_dag(
         log.debug("Writing Serialized DAG: %s to the DB", dag.dag_id)
         new_serialized_dag.dag_version = dagv
         session.add(new_serialized_dag)
+        session.flush()

Review Comment:
   On this, we should check about flushing though. My thinking is that once we 
flush and now have some id, we risk committing it differently if there's error 
while adding other items



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to