jscheffl commented on code in PR #58727:
URL: https://github.com/apache/airflow/pull/58727#discussion_r2572452802
##########
providers/ydb/pyproject.toml:
##########
@@ -63,11 +63,19 @@ dependencies = [
"ydb-dbapi>=0.1.0; python_version < '3.13'",
]
+# The optional dependencies should be modified in place in the generated file
+# Any change in the dependencies is preserved when the file is regenerated
+[project.optional-dependencies]
Review Comment:
Same here - should not be an optional dependency
##########
providers/keycloak/pyproject.toml:
##########
@@ -62,11 +62,19 @@ dependencies = [
"python-keycloak>=5.0.0",
]
+# The optional dependencies should be modified in place in the generated file
+# Any change in the dependencies is preserved when the file is regenerated
+[project.optional-dependencies]
+"common.compat" = [
+ "apache-airflow-providers-common-compat"
Review Comment:
I would not see this as an optional but mandatory dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
