aaron-wolmutt commented on code in PR #58016:
URL: https://github.com/apache/airflow/pull/58016#discussion_r2572649605
##########
airflow-core/src/airflow/ui/src/queries/useTrigger.ts:
##########
@@ -62,7 +63,22 @@ export const useTrigger = ({ dagId, onSuccessConfirm }: {
dagId: string; onSucce
}
};
- const onError = (_error: unknown) => {
+ const onError = (_error: Error) => {
+ // Check if error is a 403 (Forbidden) status
+ if (isHttpError(_error, 403)) {
+ toaster.create({
+ description: _error.message,
+ title: translate("triggerDag.toaster.error.forbidden.title", "Trigger
DAG Permission Denied"),
+ type: "error",
+ });
+ } else {
Review Comment:
Changed it to:
```javscript
const onError = (_error: Error) => {
toaster.create({
description: _error.message,
title: translate("triggerDag.toaster.error.generic.title"),
type: "error",
});
setError(_error);
};
```
It looks like this code updates the components state and also displays the
error returned by the backend. Should refactoring be a different issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
