0BVer commented on PR #58801: URL: https://github.com/apache/airflow/pull/58801#issuecomment-3594271377
Hi @jscheffl. Since this change is essentially restoring a previously removed environment variable, I was under the impression that it might be acceptable for v2-11 subject to approval. This PR re-introduces the `AIRFLOW__LOG_CLEANUP_FREQUENCY_MINUTES` environment variable in `clean-logs.sh`, which was previously missing in v2. Currently, the Helm chart (v1.16 using Airflow v2 default) already includes this parameter, but it remains non-functional because the underlying Docker image lacks the necessary environment variable support. While Airflow 3 is exciting, many production environments still rely on v2. This backport is essential for users who need this control but prefer to stay on the official upstream release without managing custom patches. Also, seeing @potiuk's approval on the original PR gave me confidence that this change might be considered for v2-11 as well (https://github.com/apache/airflow/pull/46237#issuecomment-3586593947). Of course, I am well aware that adding features to older branches can complicate maintenance and security. Please know that I fully respect the project's policies, and I will gladly comply with whatever decision you make. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
