johnslavik opened a new pull request, #58898:
URL: https://github.com/apache/airflow/pull/58898
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
At the recent HEAD 68558f3, the `./scripts/tools/setup_breeze` script failed
to install with autocompletions. To reproduce:
<details>
```bash
❯ which breeze &>/dev/null && rm -vf $(which breeze)
removed '/home/bswck/.local/bin/breeze'
airflow on main ~ apache-airflow
❯ ./scripts/tools/setup_breeze
The 'breeze' is not on path. Breeze should be installed and 'breeze' should
be available on your PATH!
Installing Breeze. This will install breeze via uv and modify your /bin/bash
to run it
Please confirm installing and modifying the startup scripts. Are you sure?
[y/N/q]
y
The answer is 'yes'. installing and modifying the startup scripts. This can
take some time!
Resolved 108 packages in 28ms
Uninstalled 1 package in 1ms
Installed 1 package in 7ms
~ apache-airflow-breeze==0.0.1 (from
file:///home/bswck/Apache/airflow/dev/breeze)
Installed 1 executable: breeze
Usage: breeze [OPTIONS] COMMAND [ARGS]...
Try running the '--help' flag for more information.
╭─ Error
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ No such command 'setup-autocomplete'.
│
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
To find out more, visit
https://github.com/apache/airflow/blob/main/dev/breeze/doc/01_installation.rst
```
</details>
In #25449, the `setup-autocomplete` command became `setup autocomplete`, but
`${BREEZE_BINARY} setup-autocomplete` in the setup script (which used to be
`./breeze` back then) wasn't fixed up --
https://github.com/apache/airflow/pull/25449/commits/31fb5ffc0ace553e3afc9c6c1084434d6daf5620#diff-7e92c11499fd4106a899eeb457db8277bd6f09dd29e683f33ae704e12fa29caeR73.
A trickier one :)
I've fixed the command invocation and the remaining stale references to
`setup-autocomplete` in the docs as well.
You shouldn't find `setup-autocomplete` now anywhere but in CSS class names.
cc @potiuk (hi! :grin:)
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
