amoghrajesh opened a new pull request, #58900:
URL: https://github.com/apache/airflow/pull/58900
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
For xcom API, `XcomModel. serialize_value` is in the end routed through to
the XcomEncoder:
https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/utils/json.py#L23-L45
which uses serde.
As part of [Move over serde library to task
sdk](https://github.com/apache/airflow/issues/58885), realised that this would
make it hard to get rid of serde occurrences in airflow core.
`XcomEncoder` in this case is used in POST/PATCH as:
`XComModel.serialize_value(patch_body.value)` when really it should not need
the `XcomEncoder` -> only JSON can come in via API and no unexpected objects,
so this one essentially is just doing: `json.dumps(value)` and not
`json.dumps(value, cls=XComEncoder)`.
Making this change is an effort to decouple serde from airflow-core.
Tried the REST API for POST and PATCH without and with my change as we see
same results:
Patch:
```python
"\"{\\\"data\\\": [1, 2, 3], \\\"metadata\\\": {\\\"timestamp\\\":
\\\"2024-01-01\\\", \\\"count\\\": 6}}\""
"\"{\\\"data\\\": [1, 2, 3], \\\"metadata\\\": {\\\"timestamp\\\":
\\\"2024-01-01\\\", \\\"count\\\": 7}}\""
```
Post:
```python
"{\"data\": [1, 2, 3], \"metadata\": {\"timestamp\": \"2024-01-01\",
\"count\": 5}}"
"{\"data\": [1, 2, 3], \"metadata\": {\"timestamp\": \"2024-01-01\",
\"count\": 6}}"
```
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
