bbovenzi commented on code in PR #58642:
URL: https://github.com/apache/airflow/pull/58642#discussion_r2577590716
##########
airflow-core/src/airflow/ui/src/layouts/Details/DetailsLayout.tsx:
##########
@@ -83,176 +86,178 @@ export const DetailsLayout = ({ children, error,
isLoading, tabs }: Props) => {
const direction = i18n.dir();
return (
- <HoverProvider>
- <OpenGroupsProvider dagId={dagId}>
- <HStack justifyContent="space-between" mb={2}>
- <DagBreadcrumb />
- <Flex gap={1}>
- <SearchDagsButton />
- {dag === undefined ? undefined : (
- <TriggerDAGButton
- dagDisplayName={dag.dag_display_name}
- dagId={dag.dag_id}
- isPaused={dag.is_paused}
- />
- )}
- </Flex>
- </HStack>
- <Toaster />
- <BackfillBanner dagId={dagId} />
- <Box flex={1} minH={0}>
- {isRightPanelCollapsed ? (
- <Tooltip content={translate("common:showDetailsPanel")}>
- <IconButton
- aria-label={translate("common:showDetailsPanel")}
- bg="fg.subtle"
- borderRadius={direction === "ltr" ? "100% 0 0 100%" : "0 100%
100% 0"}
- boxShadow="md"
- left={direction === "rtl" ? "-5px" : undefined}
- onClick={() => setIsRightPanelCollapsed(false)}
- position="absolute"
- right={direction === "ltr" ? "-5px" : undefined}
- size="2xs"
- top="50%"
- zIndex={10}
- >
- {direction === "ltr" ? <FaChevronLeft /> : <FaChevronRight />}
- </IconButton>
- </Tooltip>
- ) : undefined}
- <PanelGroup
- autoSaveId={`${dagView}-${direction}`}
- dir={direction}
- direction="horizontal"
- key={`${dagView}-${direction}`}
- ref={panelGroupRef}
- >
- <Panel
- defaultSize={dagView === "graph" ? 70 : 20}
- id="main-panel"
- minSize={showGantt && dagView === "grid" && Boolean(runId) ? 35
: 6}
- order={1}
+ <OpenGroupsProvider dagId={dagId}>
+ <HStack justifyContent="space-between" mb={2}>
+ <DagBreadcrumb />
+ <Flex gap={1}>
+ <SearchDagsButton />
+ {dag === undefined ? undefined : (
+ <TriggerDAGButton
+ dagDisplayName={dag.dag_display_name}
+ dagId={dag.dag_id}
+ isPaused={dag.is_paused}
+ />
+ )}
+ </Flex>
+ </HStack>
+ <Toaster />
+ <BackfillBanner dagId={dagId} />
+ <Box flex={1} minH={0}>
+ {isRightPanelCollapsed ? (
+ <Tooltip content={translate("common:showDetailsPanel")}>
+ <IconButton
+ aria-label={translate("common:showDetailsPanel")}
+ bg="fg.subtle"
+ borderRadius={direction === "ltr" ? "100% 0 0 100%" : "0 100%
100% 0"}
+ boxShadow="md"
+ left={direction === "rtl" ? "-5px" : undefined}
+ onClick={() => setIsRightPanelCollapsed(false)}
+ position="absolute"
+ right={direction === "ltr" ? "-5px" : undefined}
+ size="2xs"
+ top="50%"
+ zIndex={10}
>
- <Box height="100%" marginInlineEnd={2} overflowY="auto"
paddingRight={4} position="relative">
- <PanelButtons
- dagRunStateFilter={dagRunStateFilter}
- dagView={dagView}
- limit={limit}
- panelGroupRef={panelGroupRef}
- runTypeFilter={runTypeFilter}
- setDagRunStateFilter={setDagRunStateFilter}
- setDagView={setDagView}
- setLimit={setLimit}
- setRunTypeFilter={setRunTypeFilter}
- setShowGantt={setShowGantt}
- setTriggeringUserFilter={setTriggeringUserFilter}
- showGantt={showGantt}
- triggeringUserFilter={triggeringUserFilter}
- />
- {dagView === "graph" ? (
- <Graph />
- ) : (
- <HStack alignItems="flex-end" gap={0}>
- <Grid
+ {direction === "ltr" ? <FaChevronLeft /> : <FaChevronRight />}
+ </IconButton>
+ </Tooltip>
+ ) : undefined}
+ <PanelGroup
+ autoSaveId={`${dagView}-${direction}`}
+ dir={direction}
+ direction="horizontal"
+ key={`${dagView}-${direction}`}
+ ref={panelGroupRef}
+ >
+ <Panel
+ defaultSize={dagView === "graph" ? 70 : 20}
+ id="main-panel"
+ minSize={showGantt && dagView === "grid" && Boolean(runId) ? 35 :
6}
+ order={1}
+ >
+ <Box height="100%" marginInlineEnd={2} overflowY="auto"
paddingRight={4} position="relative">
+ <PanelButtons
+ dagRunStateFilter={dagRunStateFilter}
+ dagView={dagView}
+ limit={limit}
+ panelGroupRef={panelGroupRef}
+ runTypeFilter={runTypeFilter}
+ setDagRunStateFilter={setDagRunStateFilter}
+ setDagView={setDagView}
+ setLimit={setLimit}
+ setRunTypeFilter={setRunTypeFilter}
+ setShowGantt={setShowGantt}
+ setTriggeringUserFilter={setTriggeringUserFilter}
+ showGantt={showGantt}
+ triggeringUserFilter={triggeringUserFilter}
+ />
+ {dagView === "graph" ? (
+ <Graph />
+ ) : (
+ <HStack alignItems="flex-end" gap={0}>
+ <Grid
+ dagRunState={dagRunStateFilter}
+ ganttHoverRowRef={showGantt ? ganttHoverRef : undefined}
+ hoverRowRef={gridHoverRef}
+ limit={limit}
+ runType={runTypeFilter}
+ showGantt={Boolean(runId) && showGantt}
+ triggeringUser={triggeringUserFilter}
+ />
+ {showGantt ? (
+ <Gantt
dagRunState={dagRunStateFilter}
+ gridHoverRowRef={gridHoverRef}
+ hoverRowRef={ganttHoverRef}
limit={limit}
runType={runTypeFilter}
- showGantt={Boolean(runId) && showGantt}
triggeringUser={triggeringUserFilter}
/>
- {showGantt ? (
- <Gantt
- dagRunState={dagRunStateFilter}
- limit={limit}
- runType={runTypeFilter}
- triggeringUser={triggeringUserFilter}
- />
- ) : undefined}
- </HStack>
- )}
- </Box>
- </Panel>
- {!isRightPanelCollapsed && (
- <>
- <PanelResizeHandle
- className="resize-handle"
- onDragging={(isDragging) => {
- if (!isDragging) {
- const zoom = getZoom();
+ ) : undefined}
+ </HStack>
+ )}
+ </Box>
+ </Panel>
+ {!isRightPanelCollapsed && (
+ <>
+ <PanelResizeHandle
+ className="resize-handle"
+ onDragging={(isDragging) => {
+ if (!isDragging) {
+ const zoom = getZoom();
- void fitView({ maxZoom: zoom, minZoom: zoom });
- }
- }}
- >
- <Box
- alignItems="center"
- bg="border.emphasized"
- cursor="col-resize"
- display="flex"
- h="100%"
- justifyContent="center"
- position="relative"
- w={0.5}
- // onClick={(e) => console.log(e)}
- />
- </PanelResizeHandle>
+ void fitView({ maxZoom: zoom, minZoom: zoom });
+ }
+ }}
+ >
+ <Box
+ alignItems="center"
+ bg="border.emphasized"
+ cursor="col-resize"
+ display="flex"
+ h="100%"
+ justifyContent="center"
+ position="relative"
+ w={0.5}
+ // onClick={(e) => console.log(e)}
Review Comment:
Let's remove this line if we're changing this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
