amoghrajesh commented on code in PR #58888:
URL: https://github.com/apache/airflow/pull/58888#discussion_r2579772154


##########
shared/timezones/src/airflow_shared/timezones/timezone.py:
##########
@@ -305,3 +295,14 @@ def from_timestamp(timestamp: int | float, tz: str | 
FixedTimezone | Timezone =
             tz = local_timezone()
         result = result.in_timezone(tz)
     return result
+
+
+try:

Review Comment:
   Oh that was my thought initially too! I went down this road to allow having 
a conf when there is a need to have it from the shared library, but I agree 
with you, there is no real NEED for it. It doesn't need conf but just a value 
which is more easily pass-able.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to