YahelyUshpiz opened a new pull request, #58931:
URL: https://github.com/apache/airflow/pull/58931
The [extract_xcom_kill] method previously used to identify and kill the
sidecar process. However, the implementation in some Alpine/BusyBox versions
does not support the flag, causing the command to fail and the sidecar to hang
indefinitely. This commit replaces the command with a portable shell loop that
iterates over to identify processes owned by the current user. This ensures
compatibility with all Alpine versions and removes the dependency on .
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
Bug Report: KubernetesPodOperator XCom Sidecar Hangs due to pgrep missing -u
option
Title
KubernetesPodOperator XCom sidecar hangs indefinitely because "pgrep -u" is
not supported in some Alpine versions
Description
The KubernetesPodOperator injects a sidecar container to capture XCom
values. Once the main container completes, Airflow attempts to terminate this
sidecar to allow the Pod to complete.
The termination logic in PodManager.extract_xcom_kill executes the following
command inside the sidecar:
kill -2 $(pgrep -u $(id -u) -f 'sh')
This command relies on pgrep supporting the -u (user) flag to filter
processes by the current user. However, many lightweight container images used
for sidecars (like alpine) use BusyBox's implementation of pgrep. Some versions
of BusyBox pgrep do not support the -u flag, causing the command to fail with
an invalid option error.
As a result:
The kill command fails.
The sidecar container continues running (executing its infinite sleep loop).
The Pod remains in the Running phase.
The Airflow task eventually times out despite the main work completing
successfully.
Impact:
Task Hangs: Tasks that successfully finish their work will hang until the
operator times out and causing task to fail.
False Failures: Successful tasks are marked as failed due to timeout.
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
