potiuk opened a new pull request, #58944: URL: https://github.com/apache/airflow/pull/58944
With .pyc files removal after compilation we save very little space. Uncompressed sizes of regular airflow image are: Before 7.63GB After 7.66GB So we have images bigger by < 0.5% And it seems that long running containers without those files can suffer from continuous attempts to recreate the .pyc files that fail due to lack of permissions and cause negative dentries to be continuously created: https://lwn.net/Articles/814535/ Those negative dentries are created by kernel - caching the fact that a file was not available - which speeds up lookup but also takes a bit of memory. It seems that when compiled Python has the .pyc files removed, it tries to recreate them with timestamped entries every time new interpreter is started. While this is not a problem for long running processes - because those interpreters are run exactly once per container, this is a problem if you use `exec` in containers to run Health Checks. Evey health-check creates a new interpreter and every time it is created, a new negative dentries to take kernel memory. By not removing the .pyc files we increase a bit the size of the image but improve a little the startup time (no need to compile Python internal .py files, as well as get rid of the negative dentries problem. This PR likely: Fixes: #58509 Fixes: #42195 <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> <!-- Please keep an empty line above the dashes. --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
