[
https://issues.apache.org/jira/browse/AIRFLOW-6088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983667#comment-16983667
]
ASF GitHub Bot commented on AIRFLOW-6088:
-----------------------------------------
hoesler commented on pull request #6682: [AIRFLOW-6088] pass DAG processing
runtime as duration to stats
URL: https://github.com/apache/airflow/pull/6682
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/AIRFLOW-6088
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
runtime var is now a duration object, not a float
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Timing metrics dag_processing.last_* erroneously emitted as milliseconds, not
> seconds
> -------------------------------------------------------------------------------------
>
> Key: AIRFLOW-6088
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6088
> Project: Apache Airflow
> Issue Type: Bug
> Components: scheduler
> Affects Versions: 1.10.6
> Reporter: Christoph Hösler
> Priority: Minor
>
> DAG processing runtime metrics dag_processing.last_* are passed as a float
> value of seconds to the metrics client:
> [https://github.com/apache/airflow/blob/73bf718358c01cc41e5f23b914a8824a2665a28c/airflow/utils/dag_processing.py#L984]
>
> The statsd client, however, expects either a duration object or milliseconds:
> [https://github.com/jsocol/pystatsd/blob/100046bcd349013d6d78922585621159a33d1ebb/statsd/client/base.py#L22]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
