cmbilly8 commented on PR #57680: URL: https://github.com/apache/airflow/pull/57680#issuecomment-3603687857
I just got back around to working on this. I refactored the DataTable to include the row count rendering logic, which involved moving the model name translation logic to within the DataTable so I could reuse the raw model name. I also added the row count heading to the pages that it seemed appropriate on: - connections - pools - variables - task instances (already discussed) - DagRuns (already discussed) And updated the following pages that already show row counts to use the heading from the DataTable instead: - AssetsList - DagsList - HITLTaskInstances The only one that was not straightforward was the DagsList because it places the ToggleTableDisplay component between the row count heading and table (The screenshot shows how it shifted to above the row count heading). Since this component is only used on the DagsList page, does it make sense to support that layout through moving that toggle to an optional prop on the DataTable or should it be slotted in by the caller? Open to other approaches as well.<br> <img width="1932" height="562" alt="image" src="https://github.com/user-attachments/assets/425c9fe9-7984-43c8-95b3-2dbd6fe45bf7"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
