potiuk commented on PR #58952: URL: https://github.com/apache/airflow/pull/58952#issuecomment-3604063584
> In both scenarios the script assumes it's waiting for a prek job that started successfully and could fail, not for a job that didn't start (and I think we can dry-run / check that before launching everything else, since if prek fails then the entire machinery is destined to fail at some point -- otherwise we'd get a warning, not an error) Yes - we could. We already do that for other things so checking for prek (but specifically when prek should be used) is a good idea. https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/utils/docker_command_utils.py#L539 This is actually a very important point to fix those things and give as good of a message for all those edge cases as it makes it easier for new contributos. We usually discover **always** something when new person starts using things and we usually relentlessly fix it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
