jscheffl commented on code in PR #58488:
URL: https://github.com/apache/airflow/pull/58488#discussion_r2585548176
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -935,6 +935,8 @@ def trigger_reentry(self, context: Context, event:
dict[str, Any]) -> Any:
raise
finally:
self._clean(event=event, context=context,
result=xcom_sidecar_output)
+ if self.do_xcom_push:
+ return xcom_sidecar_output
Review Comment:
I assume cause is that the ruff rule
https://docs.astral.sh/ruff/rules/return-in-try-except-finally/ (SIM107) is not
enabled in the repo, that _should_ have catched this. Will put this on my
bucket list to enable... or if somebody else wants to make a PR I assume this
is an important check we are missing atm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
