amoghrajesh commented on code in PR #58506:
URL: https://github.com/apache/airflow/pull/58506#discussion_r2587746232
##########
airflow-core/docs/howto/deadline-alerts.rst:
##########
@@ -376,7 +381,8 @@ Once registered [see notes below], use your custom
references in Dag definitions
from datetime import timedelta
from airflow import DAG
- from airflow.sdk.definitions.deadline import AsyncCallback, DeadlineAlert,
DeadlineReference
+ from airflow.sdk import AsyncCallback
+ from airflow.sdk import DeadlineAlert, DeadlineReference
Review Comment:
```suggestion
from airflow.sdk import AsyncCallback, DeadlineAlert, DeadlineReference
```
##########
airflow-core/docs/howto/deadline-alerts.rst:
##########
@@ -260,7 +264,8 @@ A **custom asynchronous callback** might look like this:
from airflow import DAG
from airflow.providers.standard.operators.empty import EmptyOperator
- from airflow.sdk.definitions.deadline import AsyncCallback, DeadlineAlert,
DeadlineReference
+ from airflow.sdk import AsyncCallback
+ from airflow.sdk import DeadlineAlert, DeadlineReference
Review Comment:
```suggestion
from airflow.sdk import AsyncCallback, DeadlineAlert, DeadlineReference
```
##########
airflow-core/docs/howto/deadline-alerts.rst:
##########
@@ -58,7 +58,8 @@ Below is an example Dag implementation. If the Dag has not
finished 15 minutes a
from datetime import datetime, timedelta
from airflow import DAG
- from airflow.sdk.definitions.deadline import AsyncCallback, DeadlineAlert,
DeadlineReference
+ from airflow.sdk import AsyncCallback
+ from airflow.sdk import DeadlineAlert, DeadlineReference
Review Comment:
```suggestion
from airflow.sdk import AsyncCallback, DeadlineAlert, DeadlineReference
```
##########
airflow-core/docs/howto/deadline-alerts.rst:
##########
@@ -85,6 +86,9 @@ The timeline for this example would look like this:
Scheduled Queued Started Deadline
00:00 00:03 00:05 00:18
+.. note::
+ The import path for
:class:`~airflow.sdk.definitions.callback.AsyncCallback` was changed in Airflow
3.2.
Review Comment:
Do we need to have some sort of import redirection / shim for users who used
the old path? Is that handled already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
