amoghrajesh commented on code in PR #56187:
URL: https://github.com/apache/airflow/pull/56187#discussion_r2589099450
##########
airflow-core/pyproject.toml:
##########
@@ -187,7 +187,7 @@ dependencies = [
"statsd>=3.3.0",
]
"all" = [
- "apache-airflow-core[graphviz,kerberos,otel,statsd]"
+ "apache-airflow-core[async,graphviz,kerberos,memray,otel,statsd]"
Review Comment:
@xBis7 no they are not needed. The failure:
```
=================================================================================================
ERRORS
=================================================================================================
__________________________________________________________ ERROR collecting
airflow-core/tests/unit/api_fastapi/core_api/routes/test_routes.py
___________________________________________________________
airflow-core/tests/unit/api_fastapi/core_api/routes/test_routes.py:19: in
<module>
from airflow.api_fastapi.core_api.routes.public import
authenticated_router, public_router
airflow-core/src/airflow/api_fastapi/core_api/routes/public/__init__.py:24:
in <module>
from airflow.api_fastapi.core_api.routes.public.assets import
assets_router
airflow-core/src/airflow/api_fastapi/core_api/routes/public/assets.py:127:
in <module>
def get_assets(
airflow-core/src/airflow/api_fastapi/common/router.py:37: in decorator
self.add_api_route(
/usr/python/lib/python3.10/site-packages/fastapi/routing.py:1011: in
add_api_route
route = route_class(
/usr/python/lib/python3.10/site-packages/fastapi/routing.py:636: in __init__
get_parameterless_sub_dependant(depends=depends, path=self.path_format),
/usr/python/lib/python3.10/site-packages/fastapi/dependencies/utils.py:132:
in get_parameterless_sub_dependant
return get_dependant(
/usr/python/lib/python3.10/site-packages/fastapi/dependencies/utils.py:290:
in get_dependant
sub_dependant = get_dependant(
/usr/python/lib/python3.10/site-packages/fastapi/dependencies/utils.py:259:
in get_dependant
endpoint_signature = get_typed_signature(call)
/usr/python/lib/python3.10/site-packages/fastapi/dependencies/utils.py:196:
in get_typed_signature
signature = inspect.signature(call, eval_str=True)
/usr/python/lib/python3.10/inspect.py:3254: in signature
return Signature.from_callable(obj, follow_wrapped=follow_wrapped,
/usr/python/lib/python3.10/inspect.py:3002: in from_callable
return _signature_from_callable(obj, sigcls=cls,
/usr/python/lib/python3.10/inspect.py:2463: in _signature_from_callable
return _signature_from_function(sigcls, obj,
/usr/python/lib/python3.10/inspect.py:2307: in _signature_from_function
annotations = get_annotations(func, globals=globals, locals=locals,
eval_str=eval_str)
/usr/python/lib/python3.10/inspect.py:175: in get_annotations
return_value = {key:
/usr/python/lib/python3.10/inspect.py:176: in <dictcomp>
value if not isinstance(value, str) else eval(value, globals, locals)
<string>:1: in <module>
???
E NameError: name 'HTTPAuthorizationCredentials' is not defined
```
Is because of a fastAPI issue, unrelated to your PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
