bbovenzi commented on code in PR #56760:
URL: https://github.com/apache/airflow/pull/56760#discussion_r2589979836
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/HITLResponse.tsx:
##########
@@ -47,6 +86,13 @@ export const HITLResponse = () => {
return (
<Box px={4}>
+ {taskInstance.try_number <= 1 ? undefined : (
+ <TaskTrySelect
+ onSelectTryNumber={onSelectTryNumber}
+ selectedTryNumber={tryNumber}
+ taskInstance={taskInstance}
+ />
+ )}
<HITLResponseForm hitlDetail={hitlDetail} />
Review Comment:
The form doesn't accurately reflect the user's HITL response. Perhaps we
should add a check for `response_received`, if false, show the form, if true
show `chosen_options`, `params_input` and `responded_by_user`
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/HITLResponse.tsx:
##########
@@ -18,26 +18,65 @@
*/
import { Box } from "@chakra-ui/react";
import { useParams } from "react-router-dom";
+import { useSearchParams } from "react-router-dom";
-import { useTaskInstanceServiceGetHitlDetail } from "openapi/queries";
+import {
+ useTaskInstanceServiceGetHitlDetailTryDetail,
+ useTaskInstanceServiceGetMappedTaskInstance,
+} from "openapi/queries";
+import { TaskTrySelect } from "src/components/TaskTrySelect";
import { ProgressBar } from "src/components/ui";
+import { SearchParamsKeys } from "src/constants/searchParams";
+import { isStatePending, useAutoRefresh } from "src/utils";
import { HITLResponseForm } from "../HITLTaskInstances/HITLResponseForm";
export const HITLResponse = () => {
const { dagId, mapIndex, runId, taskId } = useParams();
- const { data: hitlDetail } = useTaskInstanceServiceGetHitlDetail(
+ const refetchInterval = useAutoRefresh({ dagId });
+ const [searchParams, setSearchParams] = useSearchParams();
+ const tryNumberParam = searchParams.get(SearchParamsKeys.TRY_NUMBER);
+
+ const parsedMapIndex = Number(mapIndex ?? -1);
+
+ const { data: taskInstance } = useTaskInstanceServiceGetMappedTaskInstance(
+ {
+ dagId: dagId ?? "",
+ dagRunId: runId ?? "",
+ mapIndex: parsedMapIndex,
+ taskId: taskId ?? "",
+ },
+ undefined,
+ {
+ enabled: !isNaN(parsedMapIndex),
+ refetchInterval: (query) => (isStatePending(query.state.data?.state) ?
refetchInterval : false),
+ },
+ );
+
+ const onSelectTryNumber = (newTryNumber: number) => {
+ if (newTryNumber === taskInstance?.try_number) {
+ searchParams.delete(SearchParamsKeys.TRY_NUMBER);
+ } else {
+ searchParams.set(SearchParamsKeys.TRY_NUMBER, newTryNumber.toString());
+ }
+ setSearchParams(searchParams);
+ };
+
+ const tryNumber = tryNumberParam === null ? undefined :
parseInt(tryNumberParam, 10);
Review Comment:
```suggestion
const tryNumber = tryNumberParam === null ? taskInstance?.try_number :
parseInt(tryNumberParam, 10);
```
We're never actually checking the task instance so the select doesn't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
