pierrejeambrun commented on issue #59082: URL: https://github.com/apache/airflow/issues/59082#issuecomment-3617244180
- 1 Will break spec interface (fastapi can't guess the returned type and document the openapi spec) - 2 Return orjson response with pydantic model in return value signature but no response validation. We considered orjson but didn't chose it at the end of the day, can't remember why. But could be good to use other external json library if those increases performance. - 3 Return orjson response with no model in return value signature but response validated using pydantic (spec problem mentioned above I believe) - 4 Response dict validated with pydantic and dict returned with model in return value signature. - 5 Return json response with model validation for response but no model in return signature Are we missing a test for what we are currently doing ? i.e -> return pydantic model and pydantic model in signature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
