jedcunningham commented on code in PR #59095:
URL: https://github.com/apache/airflow/pull/59095#discussion_r2593119919
##########
airflow-core/src/airflow/ui/src/components/DurationChart.tsx:
##########
@@ -191,9 +192,17 @@ export const DurationChart = ({
}
case "Task Instance": {
const entry = entries[element.index] as TaskInstanceResponse |
undefined;
- const baseUrl =
`/dags/${entry?.dag_id}/runs/${entry?.dag_run_id}`;
- navigate(`${baseUrl}/tasks/${entry?.task_id}`);
+ const baseUrl = buildTaskInstanceUrl({
+ currentPathname: location.pathname,
+ dagId: entry?.dag_id ?? "",
Review Comment:
Is it possible for dag_id, run_id, and task_id to be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
