dstandish commented on code in PR #59084:
URL: https://github.com/apache/airflow/pull/59084#discussion_r2593338620
##########
providers/git/src/airflow/providers/git/bundles/git.py:
##########
@@ -91,7 +91,9 @@ def __init__(
try:
self.hook = GitHook(git_conn_id=git_conn_id or "git_default",
repo_url=self.repo_url)
except Exception as e:
- self._log.warning("Could not create GitHook", conn_id=git_conn_id,
exc=e)
+ self._log.exception("Could not create GitHook",
conn_id=git_conn_id, exc=e)
+ # re raise so exception propagates immediately with clear error
message
+ raise
Review Comment:
do we need to log the exception given that it will raise anyway? probably
not i'd think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
