potiuk commented on PR #59141: URL: https://github.com/apache/airflow/pull/59141#issuecomment-3620925245
This one has a few caveats @amoghrajesh @ashb @kaxil @xBis7 : * because currently devel-common uses `from airflow.models import configuration" - shared tests are failing. We will only be able to get them succed when `configuration` is extracted to a shared distribution (and there we should inject connection class to configuration class as well rather than assume it is `from airflow.models' * this one is a little tricky - because SecretBackends are generally "public interface". The users who implement their own backend should implement it "from airflow.sdk.definitions" (and effectively from airlfow.sdk._shared)- but when the backend is used in "airflow-core" (i.e. api-server or scheduler) - the base class will be "from airflow._shared". This is not a big issue on it's own, but I think at some point in time we might implement a Protocol somewhere (currently we have no such place) which might be actually used by the users (rather than airflow.sdk.definitions) - because SecretsBackend is **NOT** only usable by "task-sdk" and yet we tell our users they should extend it. Extending from "airflow.sdk.definitions" will still work, because effectively the Backends will implement the same Protocol and both base classes are implementing the same methods (because they have shared code). And we are already checking for at least attributes being as expected. Not immediately, but something we have to think about for the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
