prdai commented on code in PR #58827:
URL: https://github.com/apache/airflow/pull/58827#discussion_r2596201882
##########
go-sdk/pkg/bundles/shared/discovery.go:
##########
@@ -147,60 +150,66 @@ func (d *Discovery) DiscoverBundles(ctx context.Context)
error {
if err != nil {
self = ""
}
+ maxProcesses := runtime.GOMAXPROCS(0)
+ g, ctx := errgroup.WithContext(ctx)
Review Comment:
it is because we don't have much control in that scenario and as there is a
context that is already provided, we can utilize that in the scenario that the
context is cancelled or Done, otherwise if we was to use plain goroutines we
won't be able to cancel the routines we spun up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
