choo121600 commented on code in PR #53216:
URL: https://github.com/apache/airflow/pull/53216#discussion_r2585974961


##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/ui/common.py:
##########
@@ -79,6 +79,9 @@ class GridRunsResponse(BaseModel):
     run_after: datetime
     state: DagRunState | None
     run_type: DagRunType
+    dag_version_number: int | None = None
+    bundle_version: str | None = None
+    has_mixed_versions: bool = False

Review Comment:
   I understand the suggestion to reuse the existing APIs, and I explored the 
frontend-only approach, However, I have some concerns.
   
   One main issue is the Grid shows multiple Dag runs at the same time, and if 
we try to fetch the version information for each run individually using 
get_dag_run, the number of API calls quickly adds up.
   
   For example, if there are 10 runs displayed, we’d end up making 11 API calls 
in total—one for get_dag_details and one for each of the 10 runs.
   
   Could you let me know if what I found out is incorrect?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to