uranusjr commented on code in PR #58993:
URL: https://github.com/apache/airflow/pull/58993#discussion_r2597269637
##########
airflow-core/tests/unit/cli/commands/test_asset_command.py:
##########
@@ -116,7 +116,10 @@ def test_cli_assets_alias_details(parser: ArgumentParser,
stdout_capture) -> Non
# No good way to statically compare these.
undeterministic = {"id": None}
- assert alias_detail_list[0] | undeterministic == undeterministic |
{"name": "example-alias", "group": ""}
+ assert alias_detail_list[0] | undeterministic == undeterministic | {
+ "name": "example-alias",
+ "group": "asset",
+ }
Review Comment:
This PR caught a bug! We didn’t correctly pass `group` in
`airflow.models.asset.AssetAliasModel` previously. This is now fixed. See
https://github.com/apache/airflow/pull/58993/files#diff-08f39b68d77f5af9f1791d161ec33de227edf406e55e9ad5e6d8e06ebf9ad524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
