ecodina commented on code in PR #59134:
URL: https://github.com/apache/airflow/pull/59134#discussion_r2599709723
##########
providers/keycloak/src/airflow/providers/keycloak/auth_manager/cli/commands.py:
##########
@@ -112,41 +117,97 @@ def _get_client_uuid(args):
return matches[0]["id"]
-def _create_scopes(client: KeycloakAdmin, client_uuid: str):
+def _get_scopes_to_create() -> list[dict]:
+ """Get the list of scopes to be created."""
scopes = [{"name": method} for method in get_args(ResourceMethod)]
scopes.extend([{"name": "MENU"}, {"name": "LIST"}])
+ return scopes
+
+
+def _preview_scopes(client: KeycloakAdmin, client_uuid: str, **kwargs):
Review Comment:
Not in this case. However, since the method is run from the decorator, all
of the `_preview_` methods must have arguments in the signature. I'll update it
to
`def _preview_scopes(*args, **kwargs)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
