uranusjr commented on code in PR #59090:
URL: https://github.com/apache/airflow/pull/59090#discussion_r2600446063


##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/dag_runs.py:
##########
@@ -218,3 +219,21 @@ def get_previous_dagrun(
         return None
 
     return DagRun.model_validate(dag_run)
+
+
[email protected](
+    "/{dag_id}/{run_id}/detail",
+    responses={status.HTTP_404_NOT_FOUND: {"description": "DAG Run not 
found"}},
+)
+def get_dag_run(dag_id: str, run_id: str, session: SessionDep) -> DagRun:

Review Comment:
   > The other option is to add this route first do that it takes priority and 
we call it as `/previous` like normal?
   
   FastAPI routing is not smart enough; putting the detail route first would 
cause all requests to be routed there and return 404 (no run named 
`"previous"`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to