ashb commented on code in PR #59241:
URL: https://github.com/apache/airflow/pull/59241#discussion_r2603117300
##########
airflow-core/src/airflow/migrations/versions/0042_3_0_0_add_uuid_primary_key_to_task_instance_.py:
##########
@@ -279,8 +280,9 @@ def upgrade():
batch_op.create_unique_constraint("task_instance_composite_key",
ti_fk_cols)
batch_op.create_primary_key("task_instance_pkey", ["id"])
- # Create foreign key constraints
- create_foreign_keys()
+ # For "sqlite" we've simply deferred FK constraint evaluation, not removed
the FKs.
+ if dialect_name != "sqlite":
+ create_foreign_keys()
Review Comment:
Given we have changed the PK on the `task_instance` table in this migration
from `(dag_id, task_id, run_id, map_index)` to `(id)` does this work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
