jscheffl commented on code in PR #59156: URL: https://github.com/apache/airflow/pull/59156#discussion_r2604518540
########## chart/docs/index.rst: ########## @@ -81,6 +82,12 @@ Features * Supported database backend: ``PostgreSQL``, ``MySQL`` * Autoscaling for ``CeleryExecutor`` provided by KEDA * ``PostgreSQL`` and ``PgBouncer`` with a battle-tested configuration +* **Security enhancements**: + + * Manual Service Account Token Volume configuration for pod-launching executors + * Defense-in-depth security with both ServiceAccount and Pod-level controls + * Compatibility with security policies like Kyverno + Review Comment: Thanks. > What are the criterias for a "significant change"? Significant means that it should be highlighted to all users because some notification is needed. Either critical parameters changed or user need to migrate or consider changes from previous deployment. Here in this case the main page describes Helm chart general features that are constant and attributes of "cool features" are summarized. But in your addition you highlighted changes, when then rather are part of newsfragments as it would be important for existing users who upgrade. If you consider it is impartant as one main product feature of the chart then it might be rather summarized as "is security compliant for X (like ISO 12345 or so)" or like "aimed to be used in strict fenced security deployments". But there are no strict rules, you just got some opinion from one of the maintainers, I am a lonely sould, there might be other opinions as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
